Feature/multicontroller #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeger-pon
requested changes
Apr 15, 2022
| } | ||
|
|
||
| get ttl () { | ||
| return this.#stdTTL |
Collaborator
There was a problem hiding this comment.
stdTTL seems like a fixed value?
Collaborator
Author
There was a problem hiding this comment.
you can set it in the constructor
| this.#foundSemaphore = false | ||
| return true | ||
| } | ||
| return this.checkSemaphore() |
Collaborator
Author
There was a problem hiding this comment.
I could rewrite to while(true) loop with a break, but this seemed better controllable
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Do need to convert to while loop
pieter-pon
approved these changes
Apr 20, 2022
|
Kudos, SonarCloud Quality Gate passed! |
apiest-pon
requested review from
denverweij-pon and
lukepon
and removed request for
bjanssen-pon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.